[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Bug: Confirming dialogs despite disabled OK-button

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-08-30 17:45:33 CEST


normally "Ctrl+Return" can be used to confirm a dialog. This internally
sends a message to the OK-button, which then executes whatever is
associated with this OK-button.

The bug: if the ok-button is *disabled* pressing Ctrl+Return executes the
code associated with th OK-button. I would expect nothing to happen at all.

In most cases (no files selected) this can do no harm. But allowing a commit
despite not meeting the minimum log size from tsvn:logminsize ist not nice.

The behaviour that a disabled control can react despite being disabled is
described here:
"A window can be disabled. A disabled window receives no keyboard or mouse
input from the user, but it can receive messages from other windows, from
other applications, and from the system."

Actually almost every dialog is affected. The attached patch is for
discussion only. All other places would need to be fixed the same way.

Should the fix be merged into 1.4.x?


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Wed Aug 30 18:04:23 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.