[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: registry key issues

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-05-29 19:51:11 CEST

Molle Bestefich wrote:

>> Even if you install TSVN per user, that still means that if another user
>> installs it too, that user will just *activate* the already existing
>> installation of TSVN for himself.
> Ah, so there is never more than one installation.
> In that case, CurrentVersion is incorrectly stored in HKCU, as I first
> said.

No! That registry key is not written/created by the installer, but by
TortoiseProc.exe when it first starts after an installation. Since
TortoiseProc is not necessarily started with Admin rights, that key must
reside in HKCU and not HKLM.
We use that key not for checking the latest version but to check which
was the latest version TortoiseProc was running under, then if it
detects that it is started for the first time with a newer version, it
can then change/adjust some settings if necessary. Settings are per-user
too, so HKCU is correct.

>> Do you have any problems with registry keys?
>> Or why do you suddenly check every single key TSVN creates?
> I needed to change a particular key, and I fell over some inconsistencies.

As long as there's no problem in using TSVN, then there is not
You see, if everything works, then you should first ask yourself if
you're not using wrong assumptions on what the registry key is used for.

> It's not like the skies are falling or anything. If we can agree
> they're inconsistencies then I can just file a low-priority issue.

I disagree here that it is an inconsistency.

>> > > No. Those are the default icons to use. Per-user settings go
>> > > automatically into HKCU for each user. That means, if the icons
>> are set
>> > > in HKCU, then those are used. If in HKCU is nothing set, then
>> those in
>> > > HKLM are used.
>> >
>> > Shouldn't default settings reside in the program itself instead of
>> HKLM?
>> >
>> > I can envision a scenario where TSVN is installed per-user, but the
>> > user does not have write access to HKLM/Software/... Does TSVN icon
>> > overlays then stop working?
>> No, because the user only needs read access to those registry keys.
> Only needs read access to perform the initial installation of TSVN?
> I think there's been a misunderstanding, that can never be true.

An installation via msi always has write access to HKLM, even if a user
doesn't have admin rights - that's why there's a service running to
handle the msi installation (msi's aren't executables, they're simply
databases handled by the installation service, running with SYSTEM
After installation, only read access to those HKLM keys is required, and
every user (ok, user "GUEST" is an exception) has read access there.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon May 29 19:51:24 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.