[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Get lock without needs-lock message

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-05-17 21:30:32 CEST

Tobias Schäfer wrote:

> I guess you're refering to svn_wc_status2_t->entry->present_props
> Unfortunately, it returns the properties of the working copy.

Yes, that's what I was referring to.

> That is actually how I implemented in the first place and the current state
> of the nightly builds.
> We should also keep in mind the request from Lübbe to show svn:needs-lock in
> a new column. I have actually mostly implemented this in the mean time, but
> haven't committed yet.


> Which value do we show in this column? The value of WC or BASE? WC would not

In case of the CSVNStatusListCtrl, I'd say the value of the WC. Because
that's what all the other columns show too (or the column header
indicates otherwise, like 'repo status').

> be problematic in terms of performance. If we show the value of BASE we
> would need the slow implementation with SVNProperties. This would be
> especially annoying because the column is hardly ever shown but
> SVNStatuslist calculates the values of all columns even if they are hidden.

True. But that wasn't a problem before because all the information was
there with a 'simple' svn_client_status() call.

> The idea could be to not calculate the values of hidden columns. This is
> problematic though if
> http://tortoisesvn.berlios.de/issues/?do=details&id=250 is implemented:
> Copy all available columns into the clipboard.

And of course, slow down the whole dialog again if the column is then
shown by the user.

> I prefer this solution:
> - use the properties of BASE to decide if the warning in the lock dialog is
> shown (rather slow)
> - use the properties of BASE to decide the value of the new svn:needs-lock
> column (rather slow)
> - change SVNStatuslist to only calculate the values of visible columns.
> Determining if a column is visible is trivial. (makes it fast again if the
> column isn't shown)
> - drop the feature request "all available columns, separated by tabs" from
> #250.
> The alternative:
> - use the properties of WC to decide if the warning in the lock dialog is
> shown (fast)
> - use the properties of WC to decide the value of the new svn:needs-lock
> column (fast)

Another alternative:
- use the properties of WC to show in the column
- use the properties of BASE for the lock dialog. This can be done
*after* the CSVNStatusListCtrl has done it's work: just get the list of
files from the control, and then fetch for every file the properties.
This has the advantage that the slowdown is done *only* where it has to
be (in the lock dialog).


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed May 17 21:31:37 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.