[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Wrong path in reverting revision

From: Kazutoshi Satoda <k_satoda_at_f2.dion.ne.jp>
Date: 2006-05-11 18:42:22 CEST

In log dialog, "Revert changes from this revision" for a path in the
changed path list seems to have a problem.

Here is the reproduction recipe.

1. Start a log dialog from a WC path.
2. Select a revision, and see the repos path which is corresponding to the
    WC path. Let's call this as the filtering path.
3. Search revisions, and pick a path in a changed path list which is
     - not starting with the filtering path
     - and longer than the filtering path
4. Open context menu for the path, and do "Revert changes from this revision".

Then a dialog pops up. But the WC path in the dialog is wrong. If I select
OK, then operation is done for the wrong path. This is very bad.

To reproduce with a TortoiseSVN WC, start a log dialog for
"X:\TSVNWC\build.txt", and pick "Modified /trunk/default.build" in r5277.
It becomes "X:\TSVNWC\build.txtuild", and the operation fails because the
path is not exist in WC.

In worse case, if the reverting change is Delete of a file, then wrong
named file is added as a copy of deleted file. No error is shown here.

Found in TortoisSVN 1.3.4 and verified with nightly r6471.

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu May 11 18:42:42 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.