>>> I've implemented this feature, see attached patch and screenshot.
>> Btw, what happened to your patch?
> I've just committed a slightly tweaked version of the patch I posted
> in revision 6460.
I tried the latest nightly, and I think the warning looks very good. Earlier I was a bit uncertain about the placement, but not any more; the color realy makes it stand out imho. It catches the eye.
However, I have found a case where the warning does not display even when one of the selected files lacks the needs-lock property. This seems to depend on the order of the selected files.
Say that I have three files.
a.png
b.png
c.png
Only b.png has the needs-lock property. If I select only b, I do not get the icon (good). If I select a and b I get the icon (good). But if I select b and c I do not get the icon (bad). Selecting a and c shows the icon as expected.
Could there be a variable that is set to a default value inside a loop or something like that?
Hans-Emil
Received on Thu May 11 13:22:55 2006