RE: Feature request: Warning on get lock

Tobias Schäfer wrote:

> I've implemented this feature, see attached patch and screenshot.

Looks great!

> Before I commit the following needs to be discussed
> - The tooltip currently doesn't name the files which are affected
> which is not optimal. There are three alternatives: only adjust the
> tooltip to say "one or
> more files", list the affected files in the tooltip or add a column
> in the lock dialog. I prefer the last alternative. Comments?

I'd prefer the additional column (showing the exclamation mark). If it's not
too much work, I'd like to see the column in the commit dialog as well, but
in this case the column would indicate an external item that is not going to
be committed.

> - Where do we place that warning.

I always find the warning in the commit dialog too unobtrusive, because I
tend to forget to commit externals (yes, the dialog that had to be dismissed
had its advantages) :-) It's 'out of the way' at the bottom right corner,
the last place where you look in a dialog.

I have another idea where we could place the (or an additional) exclamation
mark if we do not want to spend an additional column: Use it as the icon of
the OK button. This way everyone who wants to click on OK will see it.

> I've placed it in the top right

Top right is a bit better than bottom right. IMO the warning has to be
either:
- near the top, so we see it before we make our choice
- near the OK button, so we see it before we take action, near the items you
want to select, preferrably one for each item, meaning we need an additional
column

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org