Re: [PATCH] Index out of bounds when applying a patch

On 1/29/06, Tobias Schäfer <tobiasschaefer@gmx.de> wrote:

> when applying a patch TortoiseMerge crashed.
>
> I've managed to reduce the patch file which contained several files to
> bug.patch (just ignore the content). This crashes TortoiseMerge when applying
> the patch to revision 5576.
>
> I debugged TortoiseMerge and noticed an index out of bound. The attached patch
> out-of-bounds.patch prevents the crash. Since I don't fully understand the
> code, please review.

Reviewed, it's ok.

> btw, TortoiseMerge inserts unnecessary empty lines in the conflicted file, but
> seems to be by design.

Not really. If you can prevent it from adding those empty lines at the
end of a file, be my guest :)

> May I commit?

Yes, please do!

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org