Re: svnservice wrapper update

Stefan Küng wrote:
> Simon Large wrote:
>> Stefan Küng wrote:
>>> Ok, I've looked at the sourcecode.
>>> It's a mess. But even though it looks as if it works good enough.
>>
>> Anything in particular that you don't like?
>
> It's all in one single file. Would be better to split it up into several
> files to make it more readable.

LogDlg.cpp = 3124 lines ;-) But yes, I see what you mean.

>>> Can you upload it to the filesharing area?
>>
>> How do I do that?
>
> login to tigris.org, browse to "project files", click on "add new file".
> But I've just uploaded it:
> http://tortoisesvn.tigris.org/files/documents/406/29202/SVNServiceDT.zip
>
>>> I don't want it on the website directly, because we then have to keep
>>> it in our repository.
>>
>> I was hoping that if we put it in the repo then others could help
>> clean it up and make it better.
>
> They can do that now too. The sourcecode is zipped in the same file.

That's a one-way ticket, not good for sharing improvements with others.

There are lots of silly cosmetic changes that would make it easier, like
using SubWCRev instead of that C# program for munging the RC file,
sorting out some of the bad indentation, deleting commented out code.

I was thinking of the 'contrib' folder rather than the main source tree.
But if you don't want it included in the TSVN repo that's OK.

Simon

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org