Re: [TSVN] TSVN 1.2.1 explorer.exe crash

Matt Doran wrote:

> I also recently reported a crash and had no response .... probably coz
> there's not enough info to help debug the problem.

You've sent the same crashreport (or better: a report of the same
crash). But also without a stacktrace.

> I know you don't want to enable the crash handler in the shell
> extension, because you'll also be sent unrelated reports from
> explorer.exe. But what if we:
>
> * Only set the TSVN exception handler whilst running TSVN code.
> i.e. install it at the start of the shell methods and install the
> old handler at the end.

Too risky. And also people most likely don't want that. Many people are
working on shell extensions and don't want to have their
debugger/crashhandler overwritten by TSVN.

> * Try to filter out non TSVN crashes if they occur within this
> windows (ideas below).

Won't really work. Reasons below.

> I've recently added some exception handling to an application of ours
> .... and I'm wondering whether there's a way to enable the error
> reporter and conditionally send the error report only if the error
> occurred in tortoisesvn.dll?? There's an example of getting the
> module name where the crash occurred in GetModBase() in StackTrace.cpp.
> Using this it should be possible to change the
> "CustomUnhandledExceptionFilter" to only generate the error report if
> the exception was raised in the TSVN dll.

The crashhandler is used by all TSVN programs (TortoiseProc,
TortoiseMerge, SubWCRev, TortoiseBlame, ...). So we'd have to filter for
all those too. Also, Subversion itself will soon use our crashrpt.dll
too. So hard coding the module name is a very bad idea.

> If this is all a bit messy/risky. Would it be possible to have a hidden
> registry setting to enable crash handling in the shell extension ....
> and then only power users who want to help can turn this on if their
> experiencing crashes.

You shouldn't read values from the registry during a crash! You might
corrupt the whole system that way.

But: windows already has a good crash handler. If you leave the default
handler on, then (at least on XP) a crash dump file is written to
%SystemRoot%\Minidump - just send me that dump file!

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org