Re: [TSVN] can't use "Check for Modifications" for code review anymore

Kretzler Brian-R60354 wrote:
> A few iterations ago, this became a little more difficult with the
> transition from "Check for Updates..." to "Check for Modifications..."
> and the addition of the "Check Repository" button.

That's because previously the only way to check for local changes was to
start the commit dialog. And in 1.2 the dialog also checks for remote
locks, so its functionality has expanded.

> 1) The "Check Repository" button should be enabled initially, even if
> it has to wait for the local check to complete before going to the
> server and do the check. Often, I only care about the remote changes
> and not the local ones, and it would be nice to be able to just see
> those, although that is obviously a more cumbersome request to
> accommodate.

Seems reasonable. It would need some feedback so you know you have
actually pressed the button. Maybe 'Check repository' is initially
enabled, then becomes disabled from the time that you click until the
repository check is completed.

> 2) Add back the ability to compare the local working copy with the
> current head version for files that have only remote modifications. I
> can't find any indication as to why this functionality was removed.

I had not noticed that, and I can't see any reason why it should not be
there. For completeness we should have:

Local changes only:
    'Compare WC with BASE' or simply 'Diff'
We already have this, but the term 'Diff' is already in use for this
action so it may be a better one to use.

Remote changes only:
    'Compare with WC'
We already use the term 'Compare with WC' in ShowLog to mean 'Compare
remote revision with WC', so it is a good term to use.

Both changes:
    'Compare with WC' and 'Compare with BASE' and (maybe) 'Diff'
We have 3 possible comparisons. 'Compare with WC' is obvious. 'Compare
with BASE' means compare repository with local pristine copy. 'Diff'
means compare WC with BASE, but we could drop that one as it was
available before the 'Check repository' button was pressed.

I will file an issue for this.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org