Re: [TSVN] [PATCH] Repo Browser Drag/Drop import

Boris wrote:
>>Thanks for the patch. But I think I shouldn't commit that patch. It
>>seems too dangerous:
>
>
> Why do you think it's any more dangerous then the right-click import, if we
> properly warn user about drag-drop target.

In your patch, you only show an error if *no* folder is selected. But if
a folder is selected and the user drops files onto another folder,
there's no warning.
Also, if you right-click on a folder, you *know* that this folder is the
target of the import, because you do the import *on that folder*.

>>* if no folder is selected, then an error is shown
>>* but users are used to drag files in explorer to the folder they want
>>to drop the files to, not the whole window. So if a folder is selected,
>>but the user drops the files on another folder, the files will be
>>imported in the wrong (the selected, not the drop target) folder.
>
>
> What if we provide dialog/message box that warns users about drop target?
> Not the best solution but it may work ok for the time being (until new repo
> browser is ready :)).

The problem with such solutions is:
- it may take some time for the better repobrowser to get done
- it may take even longer if we do this little feature now, because then
there are less reasons to start working on the repobrowser

>>* Subversion still doesn't provide multiple targets for the import
>>command, so multiple files result in multiple revisions with the same
>>log message.
>
> I guess we can also add warning box that the same log message will be used
> for every imported file/folder, or just limit to a single file or folder
> drag-drop and warn users about that.

I thought of all that before. I even had drag-n-drop once implemented
like you did with your patch. But I removed it before I even committed
it. It's just not what a user expects when dropping things on something
that looks a little bit like the explorer.

>>I've already filed an issue about drag-n-drop in the repobrowser:
>>http://tortoisesvn.berlios.de/issues/?do=details&id=73
>
> When do you plan to start working on a new browser, and what approach do you
> plan you take? Build browser as a stand alone app, or try to create shell
> extension repo browser (something similar to webdrive), or something else.

I haven't really thought of that yet. An NSE would of course be great,
but a hell lot of work to do. And NSE's have the big disadvantage that
if they crash, they take the whole shell with them down. If the
repobrowser now crashes, it's only TSVN that quits, not the shell.

I guess it all depends on if I find a suitable control with drag-n-drop
support or not...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org