Re: [TSVN] New Icons for Show Log Search Bar

Nathan Kidd wrote:

> Using the 3505 nightly I observe:
>
> 1) the search glass icon seems to have come out of its png -> ico -> bmp
> conversion looking quite blurry. Attached is a drop-in replacement for
> logfilter.bmp with its original clarity.

Thanks for that!
Committed in revision 3519.

> 2) The cancel button gets drawn aligned top-right, but I think should be
> centered (2px padding top, right) Also, rather than being transparent
> in the space around it, it is drawing grey. See attached
> searchlog-screenshot-1.png

Centered the control in revision 3520.
Can't see that grey background here on my machine (even with the display
magnifier). So it's not possible for me to debug this :(

> 3) After clicking the cancel button a grey bar 'artifact' is left in the
> control. See attached searchlog-screenshot-2.png

Removed that artifact in revision 3521.

> 4) The button states seem a little out of order. Initial state is OK,
> but on mouseover the cancel-highlight.bmp is not shown (I think it
> should be), clicking shows cancel-pressed OK, then moving mouse off
> without releaseing mouse button shows cancel-highlight.bmp (I think it
> shouldn't).

I removed the highlight bitmap in revision 3522. The CBitmapButton class
doesn't have such a state, and I falsely used the highlight bitmap for
the 'focused' state.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org