Re: [TSVN] New Icons for Show Log Search Bar

SteveKing wrote:
> Committed your icons in revision 3443.

Many thanks for implementing this, Stefan.

Using the 3505 nightly I observe:

1) the search glass icon seems to have come out of its png -> ico -> bmp
conversion looking quite blurry. Attached is a drop-in replacement for
logfilter.bmp with its original clarity.

> Implemented a cancel button in the filter box in revision 3444.

Excellent! A few minor things:

2) The cancel button gets drawn aligned top-right, but I think should be
centered (2px padding top, right) Also, rather than being transparent
in the space around it, it is drawing grey. See attached
searchlog-screenshot-1.png

3) After clicking the cancel button a grey bar 'artifact' is left in the
control. See attached searchlog-screenshot-2.png

4) The button states seem a little out of order. Initial state is OK,
but on mouseover the cancel-highlight.bmp is not shown (I think it
should be), clicking shows cancel-pressed OK, then moving mouse off
without releaseing mouse button shows cancel-highlight.bmp (I think it
shouldn't).

All this observed on Win2003 with latest (Catalyst 4.12) Radeon 9200 SE
drivers from Gigabyte.

-Nathan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

• image/bmp attachment: logfilter.bmp