Simon Large schrieb:
>I am not sure that all of r3391 can be reverted.
>
Yes, I was just going to write the same. Stefan reverted a little bit
too much.
I made infolineA, dateA and authorA a CStringA in
CBlame::BlameCallback() to convert them to the local code page before
the infolineA.Format() command. The reason is that otherwise the
formatting in the blame file will be wrong. The number of bytes of the
author and date field change in an unpredictable way when you write them
to m_saveFile as UTF16 strings (the WriteString does the conversion to
ANSI then, which can even fail for MBCS code pages). When converting the
strings to the local code page before formatting and writing, the blame
file has a consistent format. Remember that the date string and the
author can contain Korean or Japenese characters which give more than
one byte per UTF16 character ...
Norbert
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun May 22 00:27:32 2005