Laurent CHASTEL wrote:
> Find herewith a patch to create a window to allow users to search and
> select a bug in commit window. It's in complement of the field bugid.
>
> The new button "..." in the commit window opens a window that contains a
> little webbrowser.
> The page opened in the browser is defined by the property
> "bugtraq:queryurl".
> A regular expression defined by the property "bugtraq:queryregex".
> The user has to go to the description of the bug he want to be able to
> click on the button "OK".
>
> The webbrowser control is a CHtmlView embedded in a control. (I get the
> code from an old article in MSDN Magazine)
>
> The patch includes
> - 2 new objects CHtmlCtrl (the webbrowser control) and CSearchBug (the
> window containing the previous control)
> - the modified files (ressouces, commit dialog, properties tabpage, ...)
> - the modified english documentation (DUG on bugtracking)
>
> The patch could be applied on trunk.
First: thanks for the patch. I really appreciate your work.
But there are some problems with the patch and unfortunately with the
whole approach:
- you used fixed strings for the error messages instead of string
resources which can be translated.
- instead of passing the path list to the SearchBug dlg, you could pass
the ProjectProperties object directly (would save scanning the wc again).
- why don't you just open the default browser with the specified URL? I
mean you still have to select the issue description with your control.
So it really doesn't help at all - it's the same as opening the default
browser, looking for the right issue, select the issue number and
copy/paste it into the box in the log dialog.
- I don't really like using the IE for this, not even encapsulated in a
control. Reason (apart from the obvious ones ;) ): it takes several
seconds (3 secs on my system) to show the control (not counting the
connection and fetching the webpage).
- Seems the webpage has to be in a specific format for this to work?
Then why not just use a simple text file? I mean the issuetracker could
generate such a file without big problems, and it would also save some
bandwidth.
Apart from that: do we really need this feature? I remember several
discussions about this topic on this list. And all discussions got
completely out of control because whatever we decided we could
implement, people kept asking for more and more and more features and
presented more edge cases which we'd have to cover too. So I then
decided to *not* implement something like this - it just would never end.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu May 19 21:03:21 2005