[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locked overlay

From: Molle Bestefich <molle.bestefich_at_gmail.com>
Date: 2005-04-14 08:59:06 CEST

Mark Phippard wrote:
>> Read-only is a residue from the good old DOS days, it's not guaranteed
>> to mean anything to a Windows application. Windows applications are
>> what TSVN has to do with.
> While what you say is of course technically true, I suspect most editors
> respect the property. VSS and PVCS among others have relied on this
> read-only behavior for more than a decade. I have never seen editors have
> a problem with it. Some even turn on their own overlays when it is set.

Ok, fair enough. I'll admit that I have no grasp whatsoever on how
many editors exist that will honour the attribute and how many will
disregard it.... We'll see ;-).

>>> in both cases the svn:needs-lock property is set.
>> So it is.
>> And it's effect should be that TSVN tells the user "you need to
>> lock this file".
>> And an overlay would be the right way to do that, seeing as that's how
>> we tell the user everything else. Telling the user to switch all his
>> folders to 'Detailed' view and enable an extra column in Explorer to
>> show just this information is wrong.
> I think your argument is that you want TSVN to check for the needs-lock
> property and decorate when it is present?

Yes. If, by "check", you mean check the working copy.
Apologies if I was unclear about that.

As a second priority, it would be nice if it also showed which files
are locked by one self.

> The Subversion devs decided to follow the convention that
> most other locking tools use, which is to use the read-only attribute as a
> hint to the user and their tools that a lock should be obtained before
> editing the file. I do not think there is anything else that TSVN can or
> should do.

Fair enough, if it really works in a satisfactory manner!

I thought at one point that it was TSVN that applied the read-only
bit. Seeing as TSVN is a Windows product and Subversion is
cross-platform it seemed odd that SVN would do it. Also seemed odd
that they'd change attributes on a file, as there was actually some
people over there talking about *preserving* file's attributes in the
repository itself. Well, since they obviously do change the r attrib
;-), I guess they must have spend some time testing editors and
finding out if it was a good way to do things. Enough about what I've

Changing the topic a bit. The above said, I still think it sounds odd
to let TSVN decide if a file has 'svn:needs-lock' based on whether a
file has the read-only attribute set. What if, say, your WC resides
on a Samba share on a Unix filesystem? In that case, the read-only
attribute will probably just be discarded..

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Apr 14 08:59:23 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.