Re: [TSVN] Locked overlay

Molle Bestefich wrote:

> Yes it does :-).
> It tells the user that "this file you need to take a lock on before
> you start work on it".
> It tells users that if they don't take a lock, they'll be screwing
> over all their team mates.

Ok. But it doesn't tell them that they might already have a lock on that
file. So that information that the *might* need to lock that file
doesn't really help.

>>- If you don't have the lock, the file is readonly and you can't edit it.
>
> Not true, editors are NOT guaranteed to care diddly-squat about
> read-only being set.

If an editor ignores that flag, that editor is broken. Really!

> Read-only is a residue from the good old DOS days, it's not guaranteed
> to mean anything to a Windows application. Windows applications are
> what TSVN has to do with.

Not quite true. The windows API still uses that flag. That flag works on
windows as it did on DOS, and it's also very well documented.
Yes, the ACL's give more options on how a file is readonly and for who,
but the readonly flag still says readonly-for-all-users.
For example, the WriteFile() API (a 32-bit Windows-API) throws an error
if a file has a readonly flag set, so it's not just for DOS but for
windows too.
An editor would have to remove that flag before being able to save a
file - if an editor does that without asking the user first I'd call
such an editor broken.

>>- if you have the lock, you can edit the file
>
> And if you don't, you can as well. Whoop-ti-doo..

Only if the svn:needs-lock property isn't set. No change to the current
implementation.

>>in both cases the svn:needs-lock property is set.
>
> So it is.
> And it's effect should be that TSVN tells the user "you need to lock this file".

As I mentioned now twice: it doesn't tell the user "you need to lock
this file", it only tells you that you *might* need to lock the file.
The property is set even if you already *have* locked that file!

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org