[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locked overlay

From: SteveKing <stefankueng_at_gmail.com>
Date: 2005-04-14 08:26:58 CEST

2005/4/13, Simon Large <slarge@slarge.plus.com>:
> Andrew Vaughan wrote:
> > how about
> > Show an overlay:
> > no overlay -> svn:needs-lock prop not set
> > lock icon red variant -> svn:needs-lock prop set; lock not held
> > lock overlay green variant -> wc holds lock. (svn:needs-lock
> > irrelevent)
> That's quite a good idea, although there may be problems for people with
> red/green colour blindness, and it requires 2 overlays.

We don't really have to care about those people right now. There are
enough icon sets which work around such issues already, and I'm sure
there's a way to create those icons in a way which works even for
those people.

> It's also a good summary of the information people are likely to want.
> These locking overlays should only be shown when the overlay would
> otherwise be in-subversion. In all other cases, we are doing something
> with the file, so either we hold the lock, or there is no lock. Or
> someone else has stolen it, but we can't know that.
> Stefan, is it worth asking dev@subversion to include the svn:needs-lock
> property state in the WC entry structure, or will that just make the
> status calls as slow as the get-prop calls?

I asked them to include the information from the filestat call in that
structure, so I have the information about the readonly flag 'for
free'. If the svn:need-lock information were in the status structure,
then the svn_client_status() call would take much, much longer and we
have to avoid that at all costs. The only thing how this could work is
if the svn:needs-lock property would be stored not only as a property
but in the entries file so the svn_client_status() call could read
that information in the same file access as all the other info - but
that would require a major change, including one in the wc format:
that won't happen before the 1.2 release.


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Apr 14 08:29:33 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.