[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Some requests (long)

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-03-23 17:42:04 CET

Molle Bestefich wrote:
> Re-posting, but this time inline for those who prefer reading it this way.
>
> Fernando P. Nájera Cano wrote:
>
>>23 items. All of these as of TortoiseSVN 1.1.3, Build 2699.
>>
>>General
>>
>>1. Almost whenever I press F1 I get "Error when initializating Help"
>>(in Spanish). I think I've seen that this issue got fixed some time
>>ago. In the add dialog, however, F1 and Help button shows the Help
>>without trouble.
>>
>
>
> 1. Still an issue:
> Repo-Browser URL dialog: Buggy!

Since this requires a closer look, I suggest filing an issue about this.
Also, this might include the docs, not just me ;)

>>SVN Update
>>
>>2. Right-clicking on an item should show also in bold the action which
>>will be executed when double click. (Commit dialog does it).
>>
> 2. Still an issue.

Agreed. Issue please!

>>3. Right-click on any item should give me the option to show log of
>>that item. I know you don't want to duplicate funcionality, but when
>>the update is done after a week (holidays) with a lot of activity, if
>>you want to track the changes on a specific file, you must navigate to
>>that file in the Explorer, and a useful entry here would not harm you
>>either.

There's a button "Show Log..." in that dialog after the update finishes
which will show you exactly those revisions you just updated. In the log
dialog you then can see what you want.
And isn't there already a "Show Log" entry if you right-click on a
file-entry in the log dialog?

>>4. When the update has finished, focus should be given to the "OK"
>>button, and ENTER should click OK and thus, close the dialog. If I
>>click an item and navigate throw them, ENTER should launch the default
>>action for that item, and not close the dialog.
>
> 4. Still an issue, navigating to a update log line and pressing
> <enter> closes the dialog.

This was discussed before. That's the standard behaviour of a dialog.

>>6. I have some problems with some colors, specially blue: I can't see
>>them very well. I use my monitor with low bright and contrast, and for
>>instance the blue used is quite dark. Maybe it could be changed to
>>some lighter color?
>
> 6. Feature request. No comments.

That blue color (if you're talking about the progress dialog used for
updates/commits/...) is a system color. You can change that color in
your windows settings.

>>SVN Commit
>>
>>7. In older versions - I can't recall when exactly, if I have a lot of
>>unversioned files in a tree, if I checked an unversioned folder, it
>>was selected and also all its children. Now when I checked an
>>unversioned folder it is selected but only it. Is this the intended
>>behaviour? What about some popup entries: "mark/unmark with children"?
>>
> 7. Don't know what the intended behaviour is. Auto-selecting children
> when choosing unversioned folders to commit might be reasonable.

This has been changed due to some discussions on the list. We could
change this again, but I think someday we have to stick to a certain
behaviour and not have me changing it every few weeks.

>>8. There is no action for unversioned files. Maybe launching its
>>standard editor? If so, then a bold popup entry "Open" should be
>>append to its menu. If not, what about adding an entry called "Open"
>>but not bold, so I can launch the file and remember its contents
>>without having to navigate throu Explorer until I find it? Open exists
>>for versioned files.
>
> 8. Seems very reasonable.

An entry "Open" is ok, but definitely _not_ as a doubleclick action.
That would disturb me a lot since I'm used to doubleclick on a file and
have TMerge pop up really fast. Sometimes files are associated with a
'big' application which takes ages to load and I don't like it if e.g.
VS.NET starts up again just because I accidentally clicked on such a
file. Also, you could accidentally click on an exe file or a dll (dll's
are associated with regsvr32 on my machine, which would really annoy me
if that would happen accidentally!).

>>9. If I select one unversioned file, I get a popup menu called "Add To
>>Ignore List". If I select two unversioned files using Ctrl or Shift,
>>why can't I get them ignored at a time?
>>
> 9. The Explorer dialog has this feature, so seems reasonable to make
> the ignore feature in the Commit dialog resemble it. Or decide to
> only have it in one place (which would be my first option).

AFAIK the commit dialog now also shows a submenu to ignore by mask.
Having multiple files ignored at the same time is a bad idea - if you
have to ignore many files at once, you should better think again about
your file-layout or use a mask to ignore files.

>>10. If I select one versioned file, I get a popup menu called "Show
>>differences as Uniffied Diff". If I select two versioned (modified)
>>files, why can't I get a uniffied diff. If I can get it for a whole
>>folder, shouldn't I be able to get it for some individual files?
>
> 10. Seems reasonable. The TSVN menu in Explorer allows this.
> Generally there seems to be lots of menu items missing when multiple
> items are selected in the commit dialog (perhaps update dialog also?).

What's the point in comparing two files from the commit dialog?

>>Explorer popup
>>
>>11. The same as #9: if I right-click a modified file, I get "Create
>>Patch". Why not if I right-click two modified files?

Because that would require two pathfiles to be created. The subversion
function which does this only takes one file as an argument, not a filelist.

>>12. Blame is not useful if two versioned files are selected - it will
>>only blame one of them. Either open as many blame files as files
>>selected, or just don't show that entry in the explorer popup.
>
> 12. Still an issue.

So file this issue ;)

>>Config dialog
>>
>>13. A minor issue: the text "Context Menu" in the "Look and Feel" tab
>>could better say "Items I want to see in the top context menu". I know
>>about the hint, but not everyone knows about that, and when I read
>>"Context Menu" I always tend to think all the items I don't check
>>there won't be ever shown.

>
> 13. Still an issue. The ticked items should be reversed.
> Alternatively, the text should read Top Context Menu" or so. I'd
> prefer reversing the ticked items.

Again: please file an issue about this.

>>Right-click - Subversion tab
>>
>>15. I think there can be a little button next to the combo where
>>tsvn:logtemplate and so on are. The button could say "What's this?" or
>>just "?" and it could show a MsgBox with the hint of the property
>>selected. Yes, I know there are hints if you put the mouse over the
>>textarea below, but there are people that mainly uses the keyboard.
>
> 15. Still an issue. Agree with reasoning, disagree with solution.
> IMHO the Subversion tab on the Properties sheet of a file should
> respond to the F1 key just as the other TSVN dialogs does.

Doesn't the F1 key work? Oh boy: another issue.

>>16. There is no hint for checkbox "recursive". It could tell you that
>>some properties are not available for recursiveness (sp?)
>>
> 16. That should be mentioned in the help page that should show up when
> the user presses F1.

Agreed. Add this to the previous issue please.

>>17. Last commit revision date and Property Status date are cut. In
>>Spanish I see "15:20:33, sabado, 12 de marzo de 200" -- year
>>incomplete. Not a big issue either.
>
> 17. Perhaps still an issue. Don't know if the field fills to the
> right edge of the dialog. It should be fixed if it doesn't.

I've made the string length bigger some time ago. So it should be fixed
in HEAD.

>>Revision Graph
>>
>>18. If you click "Cancel" when gathering information, Cancel button
>>gets disabled but the process is still there for some seconds (about
>>15 in my tests) until a "User cancelled" MsgBox appears. Could it be
>>cancelled quickly?

Unfortunately, it can't. If you press "Cancel", then TSVN immediately
set's the 'cancel' flag in the Subversion callback, but Subversion
doesn't always cancel immediately :(

> 18. Still an issue. Not sure if this can be fixed easily.
> Additionally, the current nightly produces visual artifacts (upper
> right corner), and the "resize" grabber (lower right corner) is odd -
> see screenshots.

If you can reliably reproduce this and of course provide either a small
repo or reproduce it with some other public repository then you should
file an issue. Otherwise I won't be able to fix this...

>>19. Is there any way to launch this graph from Repository Browser? I
>>cannot find it, and I think it could be useful instead of having to
>>checkout a WC to launch it.
>
> 19. Feature request. No comments.

Please file an issue.

>>21. A "Help" menu item should appear in the main menu of the window.
>>Also a "File | Exit" as a File menu exists - These two are to make the
>>window more Windows-like.
>
> 21. Still an issue.

So file it please ;)

>>Export
>>
>>22. I would like to have the "Export unversioned files too" checked by
>>default. Maybe an entry in the options dialog.
>
> 22. Feature request. I disagree strongly.

Me too! You already can export easily by right-dragging. Choosing
"Export extended here" instead of "Export here" isn't really a big deal.

>>Config dialog (2)
>>
>>23. Because of #22 and #14: You could add a new section "Advanced" to
>>group up some assorted settings, say everything you can tweak via
>>regedit, or things like #22 or #14. It could be a check-list in a
>>scroll area, like IE's Tools - Settings - Advanced Settings (no need
>>to put icons and so on) or Windows Explorer - Tools - Settings - View
>>- Advanced settings. I know that it can be quite "risky" to expose
>>some options to non-advanced users, but exposing "Show all hidden
>>files and folders" and "Not show system protected files" are risky too
>>but Microsoft put them there to be checked/unchecked. Remembering what
>>the regedit option was is... unconfortable.

I don't like that idea. All the settings a normal user can/want/should
change are already in the settings dialog. All those which are dangerous
are not there and only documented in our docs. And even Microsoft has a
_lot_ of documented registry entries which a user can change with
regedit but not with a settings dialog.

Stefan

P.S. You're really late with your list here! I mean, when we start
discussing about releasing soon you'll post such a big list? Why
couldn't you post this list earlier so we would have had the time to fix
and *test* it?
That said: I'm sorry but your request won't make it into the 1.1.4
release anymore - you're just too late.

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Mar 23 17:42:38 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.