[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Question about 2560

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2005-01-28 13:14:32 CET

At 13:06 28/01/2005 +0100, you wrote:

>The bug is not that SVN::ReleasePool() frees the pool! The problem is
>that we allocated the config stuff in pool and not parentpool (which
>doesn't get freed by ReleasePool()).
>But you're right, my 'fix' was not right.

Yes, I did think about that. But given that there are now about half a
dozen functions in SVN using local pools of their own, I thought we might
as well stay consistent with them.

>No. The error baton is always allocated in the topmost pool. That is in our
>case parentpool.

OK, that's good.

>I've changed the following:
>- allocate the config stuff in parentpool instead of pool

Fine, that was probably the intention anyway, wasn't it!

>- use the recommended svn_client_create_context() API to initialize the
>context
> instead of our own initialisation (which was required when
>svn_client_create_context()
> wasn''t available yet).

Yes. (It doesn't actually do anything very interesting at the moment,
though, does it!)

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jan 28 13:15:31 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.