[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] "Show overlays only in explorer" contentions

From: Pete Gonzalez <pgonzalez_at_bluel.com>
Date: 2005-01-20 05:59:00 CET

At 12:08 PM 1/6/2005, you wrote:
>>I felt a little stupid, but I don't think my interpretation was unusual. IMO
>>there's something fundamentally wrong about equating Explorer.exe with
>>Windows Explorer, since the "explorer" functionality can be accessed
>>from many different processes (e.g. from iexplore.exe). I mean, the "e"
>>isn't even capitalized in that caption. :-)
>
>Personally, I think one could make a good argument that the logic is
>backwards, really. The option is there for people who want to *disable*
>applications other than the shell.

I agree, it would be easier to understand if the checkbox said "Hide
icon overlays in all applications except Windows Explorer." I also
reiterate my suggestion for a more precise explanation in the tooltip.
The current wording makes it quite difficult to find the checkbox when
working backwards from the unintended result.

> From Win2K onwards we could probably do GetShellWindow and then
>GetWindowThreadProcessId as a test for if we were in the shell process.
>That might even work with GetDesktopWindow, but I don't know, and we
>walk straight into a minefield of OS version compatibility.
>What do you think about that as an approach?

That sounds much less "hacky", since GetShellWindow() is a standard
interface documented by Microsoft, and supportable in principal by 3rd
party shells.

>> (Or an even better approach might be to let the user input a list of
>>process names.)
>
>Would that be processes TSVN is allowed in, or processes it's not?

The former, since the intent of the checkbox is to keep TSVN from
slowing down the common dialogs. (So maybe the "ideal" solution
would detect ComDlg32.dll instead?) After reading SteveKing's post,
I agree that this may just clutter the GUI. I'd be happy with an
obscure configuration option in a text file somewhere. On the other
hand, I recently upgraded my computer and the dialogs are loading
faster now, so maybe that counts as a fix. :-)

Cheers,
-Pete

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Jan 19 06:02:41 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.