[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] "Show overlays only in explorer" contentions

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2005-01-06 18:08:30 CET

At 11:39 06/01/2005 -0500, you wrote:

>Finally I got out the debugger and investigated the problem, which
>eventually took me to this little hack in TortoiseSVN IconOverlay.cpp:

It's a bit rude to describe it as a hack! It used to be much worse than
that...

>I felt a little stupid, but I don't think my interpretation was unusual. IMO
>there's something fundamentally wrong about equating Explorer.exe with
>Windows Explorer, since the "explorer" functionality can be accessed
>from many different processes (e.g. from iexplore.exe). I mean, the "e"
>isn't even capitalized in that caption. :-)

Personally, I think one could make a good argument that the logic is
backwards, really. The option is there for people who want to *disable*
applications other than the shell.

>I would like to suggest that we rename the checkbox to "Show overlays only
>for the Explorer.exe process," or at least mention in the tooltip that
>dialogs are not the only place where the overlays will be disabled.

That seems fair enough. The whole business is rather difficult to explain
- 'The shell' is an elusive concept at best, and as soon as you mention
Explorer people think you're talking about IE.

 From Win2K onwards we could probably do GetShellWindow and then
GetWindowThreadProcessId as a test for if we were in the shell process.

That might even work with GetDesktopWindow, but I don't know, and we walk
straight into a minefield of OS version compatibility.

What do you think about that as an approach?

> (Or
>an even better approach might be to let the user input a list of process
>names.)

Would that be processes TSVN is allowed in, or processes it's not?

>It's not a big deal, but maybe it could have saved me those hours I wasted
>debugging COM interfaces. ;-D

I doubt it! You can't blame us for the speed you debug at...

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 18:09:06 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.