[TSVN] Tempfile vs. actual path

Guys,

The TortoiseProc command line currently takes a /path: argument, which is
either a name of a temporary file containing CRLF separated paths, or is a
single path, or is a list of paths separated by asterisks.

Some commands take one form, some take another. Some can have their
behaviour modified by the /notempfile flag, some ignore this.

If you get this wrong in certain ways with certain commands, TortoiseProc
will punish you for your stupidity by deleting the file whose name you
mistakenly passed as the /path: argument. If you it wrong in other ways,
TortoiseProc might crash.

Although I appreciate that this represents a rich seam of software
archeology, there for the pleasure and amusement of our grandchildren,
*personally*, I find it rather a pain. Especially when it induces me to
break things (like import), which Stefan then has to fix...

Of course, it doesn't make much difference to most end-users, because the
shell extension knows all the various rules and acts accordingly.

I would like to propose the following changes:

1. All commands default to assuming that the /path: argument is a temp file
containing a list of paths.
2. To avoid point 1 causing death and destruction during the changeover,
TortoiseProc should only delete a path temp file if it has a .tmp extension.
3. All commands should honour the /notempfile switch.

If we do this, then I can hoist all the processing of the tempfile out to
one place at the top of TortoiseProc, and pass a reference to a
CTSVNPathList around to everything else.

Can anyone see any problems with this? (Other than the spate of
regressions I shall cause as I blunder about in the code)

Clearly people who have written batch files to talk to TortoiseProc *might*
have to change them, but at least they'll be changing them to match the
documentation, and I think point 2 above will prevent them having files
suddenly deleted.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Jan 10 21:45:52 2005