Re: [TSVN] Scintilla (was Re: [TSVN] New release soon?)

Will Dean wrote:

> I agree. I think all dialogs should cancel with escape, because it's
> the standard way Windows works. It drives me mad to hit escape to
> dismiss something only to realise I have to go to the mouse to get rid
> of it. Or do some combination of F4 and a modifier (can't ever remember
> that one).

Ctrl-F4 closes the current MDI window, Alt-F4 closes the app window
(just a reminder ;)

> If we're worried about losing log text accidentally, we should add some
> kind of confirmation message if the text has changed.

That's not necessary: if you hit cancel, the log message you've entered
is still added to the log message history combo and available next time
you start the commit dialog.

One problem of having ESC closing the window: the esc key is used in
Scintilla (and many, many other text editors too btw) to close the
autocompletionlist, close the infotip text, ...
So I have to write a check if nothing like that is currently visible
before having the dialog closed when the user presses ESC.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org