[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re[2]: [TSVN] Strange behaviour with Tortoiseproc.exe /command:commit /notempfile

From: Fernando P. Nájera Cano <yo_at_FernandoNajera.es>
Date: 2005-01-07 21:10:26 CET

Estimado SteveKing,

>> Picture on the left: commit dialog using TortoiseProc.exe /path:.
>> /command:commit /notempfile. Picture on the right: commit dialog
>> via context menu.

S> TortoiseSVN does not work with relative paths! If you use '.' or '..' as
S> a path, expect weird behaviour!

I could understand that no files are shown, or files from another
path... but in this case, the files are correctly shown but the first
letters are off... It is not consistent, because I cannot infer that
the cause of this behaviour is using relative paths.

When using an absolute path it works as expected.

BTW, doing some tests:

* /path:c:\. gives you an empty error dialog.
* /path:c:\.. gives you "Path 'c:\..' ends in '..', which is unsupported for this
operation".
* /path:c:\tortoisesvn\. gives you the same as my picture.
* /path:c:\tortoisesvn\.. gives you the same error as with "c:\.."
* /path:c:\tortoisesvn\.svn shows you all files under .svn!
* /path:c:\tortoisesvn\.\build.bat says "c:\tortoisesvn is not a
working copy" (but it is)
* /path:c:\tortoisesvn\..\tortoisesvn" says "c:\tortoisesvn\.. is not
a working copy"
* /path:c:\tortoisesvn\..\tortoisesvn\" says the same.

As you can see these results are quite distinct, but the cause is the
same: relative paths.

So my suggest:

if ((path ends with "\." or "\..") ||
    (path is exactly "." or "..") ||
    (path contains "\.\" or "\..\")) {
  show error "relative paths are not supported";
  break;
} else if ((path ends with "\.svn") ||
           (path contains "\.svn\")) {
  show warning "are you sure of what are you trying to do????!!!";
} else {
  proceed;
}

I know that this is a really non-important change as the command line
is not widely used, but that way a stupid tester like me would know
what's wrong :). Seriously, I think that at least the behaviour of
those test cases should be consistent.

Best regards,

Fernando Najera

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jan 7 21:11:08 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.