At 20:25 06/01/2005 +0100, SteveKing wrote:
>Yes. I've done some more tests now myself and it works as it should. I
>guess the crashes I saw when I first tried the critical sections weren't
>because of them but because of something else.
The usual thing I do with CritSecs is forget to initialise
them. (Actually, I always use something like CComAutoCriticalSection
nowadays, so that's not a problem any more.)
>The critical sections never made it into the repository - I had a crash
>right at the beginning when I tried them. I then switched to Mutexes and
>tested again where I didn't get a crash. Seems the crashs weren't because
>of the critical sections - maybe the crash didn't happen with the mutexes
>because they're slower? I don't know.
Yes, maybe.
>I committed a change in revision 2348 which makes the shell extension use
>critical sections instead of mutexes. I did some testruns with multiple
>processes and it didn't crash. But I would appreciate it if you could do
>some tests yourself - you once told me that you have a four processor
>system available ;)
Well, I have a twin-Xeon, which looks like four processors. I also have a
test harness which can call the shell extension dll from lots of
threads. I know that crashes straight away if you take the mutex out, so I
shall try the latest build.
Cheers,
Will
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 20:40:21 2005