Re: [TSVN] status cache, mutexes

Will Dean wrote:
> At 19:58 06/01/2005 +0100, you wrote:
>
>> Hmmm - I've extended the test a little. Now it seems that the dll has
>> different global variables for each process as I would expect. I'll do
>> some more tests and report back...
>
> They do. And there's a new SVNFolderStatus object being created for
> each process.
>
> I just added some trace code to the release build of the DLL, tracing
> the PID from the constructor of SVNFolderStatus.
>
> After killing all the processes which had the DLL loaded, I copied the
> new DLL into place, and restarted the shell, then Eudora, then VS.
>
> Here's what was going on on Dbmon during that (I've removed the
> irrelevant cruft):
>
> 6424: Constructing new status cache, processId: 0x1918
> 7380: Constructing new status cache, processId: 0x1cd4
> 6308: Constructing new status cache, processId: 0x18a4

Yes. I've done some more tests now myself and it works as it should. I
guess the crashes I saw when I first tried the critical sections weren't
because of them but because of something else.

> Can you suggest a the last rev in the repos which used critical
> sections, or did it never make it that far?

The critical sections never made it into the repository - I had a crash
right at the beginning when I tried them. I then switched to Mutexes and
tested again where I didn't get a crash. Seems the crashs weren't
because of the critical sections - maybe the crash didn't happen with
the mutexes because they're slower? I don't know.

I committed a change in revision 2348 which makes the shell extension
use critical sections instead of mutexes. I did some testruns with
multiple processes and it didn't crash. But I would appreciate it if you
could do some tests yourself - you once told me that you have a four
processor system available ;)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org