[TSVN] Possible bug in

Stefan,

CSVNStatusListCtrl::GetStatus

Contains the following code, around line 274:

// check if the unversioned folder is maybe versioned. This
// could happen with nested layouts
if (SVNStatus::GetAllStatus(temp) != svn_wc_status_unversioned)
         continue; //ignore nested layouts

I don't believe that 'temp' is assigned to anything at this point - can you
check this?

I am in the process of trying to reduce the number of deep string copies
which are made for each file (currently about 6.5 in my test case) and as
part of that, I am trying to make sense of all the strings in that method
which are called things like 'temp', 't', 'filename', 'temppath', etc.

(In fact, more than making sense of them, I'm going to try and get rid of
them!)

GetStatus is now an incredibly complicated function, and I think there is a
lot of unnecessary copying of stuff going on - do you mind if I try and
refactor it somewhat?

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Dec 16 10:55:29 2004