Re: [TSVN] More on Commit dialog performance

Will Dean wrote:
> At 10:15 16/12/2004 +0100, you wrote:
>
>> Have to correct here myself: TSVN does already store all the data
>> itself. So I'll start working on virtualizing the listcontrol...
>
>
> Before you do this, are you sure this is a problem?

Well, the change wouldn't be hard to implement.

> If the problem is the need to do incremental redraws of the listview, it
> might be that copying the strings is irrelevant.
>
> Of course, if you've profile data to say that the 'Insert' is the slow
> bit, and that it would be less slow if it didn't contain any strings, I
> take this all back.

I've done some more tests. And now (with the reduction of
ResizeColumns() calls), the speed depends mostly on the network and the
harddisk. You can easily see that (without a profiler) when checking out
a large tree: the CPU usage stays below 30% (on my 700MHz laptop), but
the disk is in heavy use. So I guess I'll drop the virtualization of the
control - it wouldn't improve performance much more anyway.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org