[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Commit dialog perf patch

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2004-12-16 09:54:34 CET


The attached *draft* patch contains a number of things which improve the
performance of the commit dialog.

Things I discovered:

1. Looking-up icon-indices for the listview items is very slow (this
probably depends on how many registered file types there are on a
machine). I have added a cached which keys a map on file extension to
improve this somewhat. (It makes a huge difference in the rather
artificial situation where one toggles the 'show unversioned' checkbox on
and off a lot, but a useful difference otherwise.)

2. I've tried to improved the efficiency of some very heavily used
operations, like the UTF conversion routines and checking against ignore
lists. I'd appreciate a review of some of this.

3. I've cleaned-up a few places where functions were being passed 'const
CString blah rather than const CString& blah. The MFC/ATL CString actually
uses refcounting, so inadvertent copies like this are actually very cheap,
but I don't think that const CString blah was the intention.

Now that the Stat() function is not doing is 100 million string compares,
there doesn't seem to be any particular pressure in this area, so I've not
changed anything else there.

Comments welcome!



To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Thu Dec 16 09:56:08 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.