Nathan Creek wrote:
>> I think what is confusing here is that the files are listed as deleted
>> but not added. To present a consistent picture to the user the list
>> should read either:
>>
>>>> Sub2: deleted
>>>> Sub2/File1.txt: deleted
>>>> Sub2/File2.txt: deleted
>>>> Subfolder/Sub2: added
>>>> Subfolder/Sub2/File1.txt: added
>>>> Subfolder/Sub2/File2.txt: added
The problem here is that Subfolder/Sub2/File1.txt and
Subfolder/Sub2/File2.txt have a Subversion status of
svn_wc_status_normal and not svn_wc_status_added (!!?). You can easily
see that when you use the CL client.
But Sub2/File1.txt and Sub2/File2.txt have a status of
svn_wc_status_deleted. Again, the CL client lists those as deleted too.
>> or more simply:
>>
>>>> Sub2: deleted
>>>> Subfolder/Sub2: added
Well, that might be possible to do...
> I think Simon has it right. Listing files as added also is an
> alternative that i considered, but i didn't mention it because they
> don't get listed as added and deleted in the log after a commit.
>
>> What happens if you deselect any of those file adds and deletes is a
>> worry. Probably it should refuse to commit. Maybe you should simply
>> filter out the file deletes, so the move _has_ to be done recursively.
>
> To me it does make sense to be forced recursive, but I guess the other
> thing to be considered is that there is no distinction between something
> being moved and something being deleted. But if someone uses
> TortoiseSVN->Delete on a folder then it would probably make sense to
> have that forced recursive also??
I can't just force a recursive commit. If the user deselects one or more
files from the list, then the commit must be done non-recursively. And
it's also not possible to only commit some entries recursively and the
rest non-recursively. Either the whole commit is recursive or non-recursive.
But Subversion will throw an error if a folder deletion is attempted
with a non-recursive commit.
> I don't really mind if it's changed to include the added files, or to
> exclude the deleted files.
> If the deleted files are excluded then to let the user know more about
> what is happening there could be extra information in the Text Status
> field after added or removed.
>
> Sub2: deleted (0 folders, 2 files)
> Subfolder/Sub2: added (0 folders, 2 files)
Well, just for having a little bit more information about something a
developer _should_ know about anyway (if not, then giving such a
developer commit access might be dangerous for the project!) this would
just be too much work. Implementing that would require several days of work.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Nov 26 18:31:30 2004