Simon Large wrote:
> SteveKing wrote:
>>Why do you think that File1.txt and File2.txt should not be listed?
>>They're getting deleted too. So they should be listed (I think). Sure,
>>you can't commit Sub2 without committing Sub2/File1.txt and
>>Sub2/File2.txt, but at least you can see what's getting deleted when
>>you delete Sub2.
>
> I think what is confusing here is that the files are listed as deleted
> but not added. To present a consistent picture to the user the list
> should read either:
>
>>>Sub2: deleted
>>>Sub2/File1.txt: deleted
>>>Sub2/File2.txt: deleted
>>>Subfolder/Sub2: added
>>>Subfolder/Sub2/File1.txt: added
>>>Subfolder/Sub2/File2.txt: added
>
>
> or more simply:
>
>
>>>Sub2: deleted
>>>Subfolder/Sub2: added
>
I think Simon has it right. Listing files as added also is an
alternative that i considered, but i didn't mention it because they
don't get listed as added and deleted in the log after a commit.
> What happens if you deselect any of those file adds and deletes is a
> worry. Probably it should refuse to commit. Maybe you should simply
> filter out the file deletes, so the move _has_ to be done recursively.
To me it does make sense to be forced recursive, but I guess the other
thing to be considered is that there is no distinction between something
being moved and something being deleted. But if someone uses
TortoiseSVN->Delete on a folder then it would probably make sense to
have that forced recursive also??
I don't really mind if it's changed to include the added files, or to
exclude the deleted files.
If the deleted files are excluded then to let the user know more about
what is happening there could be extra information in the Text Status
field after added or removed.
Sub2: deleted (0 folders, 2 files)
Subfolder/Sub2: added (0 folders, 2 files)
What do you think?
Cheers,
Nathan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Nov 26 00:33:19 2004