Nathan Kidd wrote:
> Simon Large wrote:
..snip..
>> Adding line numbers to TBlame sounds not too hard, but would take up
>> yet more space in the info area. If we are going to do this I would
>> suggest moving the date/time info into the log message hint box.
>> There is also a potential confusion between line number and revision
>> number, although it is fairly obvious when you look at several lines
>> and see one number incrementing. (Adding headings is also
>> non-trivial due to lack of MFC).
What I have often seen (I nearly said 'is usually done') is to have the line
numbers more obvious is to give them a different background colour.
>> What do others think about making this change?
I think line numbers would be of benefit, but then I also think that a
find/search utility would be of benefit too...
..snip..
> Simon, I think your suggestion about moving the
> date-time to the log message is very good.
As an option possibly - and it would be nice to have some control over the
formatting,
thanks to many years on mainframes I actually prefer my date/times to look
like this:
041102 16:58:35, or even 041102:16:35 to save even more space - with an
option to show the seconds too if desired. I'm even tempted to go as far as
041102:1658 personally.
Also if one were to move the date and time into the log message pop-up then
why not the author also?
For those who prefer it all they would need would be the revision and line
numbers.
> To avoid revision number vs. line number confusion, why not
> keep the revision number on the left, but put the line number
> after the username, right next to the actual lines?
This makes sense to me. This is how some of my editors work and is fairly
obvious.
> In my work, at least, a typical "blame" operation goes like this:
> 1. I svn update and attempt to compile code
> 2. gcc Error: Line 327 of foo.c is completely borked.
> 3. I run blame, attempting to find out who borked line 327.
>
> Thus in this use-case, searching is not an issue, easily finding the
> line-number is. The other day I was trying to find line one-thousand
> and something or other and ended up loading the file in vi,
> checking the status line to see what % of the file that line was at,
> and going back to the blame window and guesstimating on the scroll bar
> how far that % was.
> (Why didn't I just open in a text editor? Because the pop-up log
> info, and line highlighting is *very* useful; I found it easier to do
> this awkward vi dance than mentally grouping
> same-revision-number lines
> and doing however many "svn -log -rXXX" operations as necessary.)
>
> All this IMHO.
Ideally it would be nice to be able to control the format of the date/time
displays and the order (and presence) of the columns.
More practically it may be the best compromise to move the date, time and id
fields into the log pop-up and only show the revision and line numbers. Line
number display should be optional as well.
Another idea is a second window that contains only a list of the revision
numbers in the file being examined and their associated date time and id
fields. This could be 'summoned' by a button if that is practicable.
This may make the blame window a little neater.
Or this could be a scrollable section or pane at the bottom/top of the blame
window, and pointing/clicking these lines could highlight the relevant lines
of code associated with the clicked revision. If you see what I mean.
There's even the possibility to show only those lines for the selected
revision...
One thing I dislike about the blame is that the highlighting doesn't always
make it obvious how may revisions are in the file - I have a file with, say,
revisions 124,215,216 and I can 'overlook' revision 216 because it's only
one line (assuming the other fields don't make it stand out). I can't think
of a way to make it more obvious without something like I have suggested.
Bill
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
This e-mail transmission is strictly confidential and intended solely
for the person or organisation to whom it is addressed. It may contain
privileged and confidential information and if you are not the intended
recipient, you must not copy, distribute or take any action in reliance
on it. If you have received this email in error, please reply to the
sender as soon as possible and delete the message. Please note that we
are able to, and reserve the right to, monitor e-mail communications
passing through our network.
The views expressed in this email are not that of the company unless
specified within the message.
The inclusion of this footnote indicates that the mail message and any
attachments have been checked for the presence of known viruses.
If you have any comments regarding our policy please direct them to
postmaster@cox.co.uk
________________________________________________________________________
This email has been scanned for all viruses by the MessageLabs Email
Security System. For more information on a proactive email security
service working around the clock, around the globe, visit
http://www.messagelabs.com
________________________________________________________________________
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Nov 2 18:25:25 2004