Re: [TSVN] Another go at a patch for SVNFolderStatus

At 19:18 28/10/2004 +0200, you wrote:

>>There is definitely a bug in there are the moment, which is the following:
>>The OS asks for
>>\will\tsvntest\top\sub1
>>(which is a folder)
>>TSVN then mistakes that for a file (by falling out of the if(isFolder)
>>clause, chops the end off and
>>asks SVN for the status of the folder:
>>\will\tsvntest\top
>
>And that's usually correct. Imagine the following:
>\will\svntest\top\sub1
>\will\svntest\top\sub2
>\will\svntest\top\file1
>\will\svntest\top\file2
>
>now, the shell asks for the status of
>\will\svntest\top\sub1
>
>if we then get the status for
>\will\svntest\top
>we will fetch the status for _all_ the folders and files in that folder,
>which includes sub1, sub2, file1 and file2 in one step. That's what this
>is about.

OK, I see what the confusion is here. You're talking about it asking for
the status of the subfolder 'sub1', whereas I'm talking about when I'm *in*
the folder sub1.

If I'm *in* sub1, I don't want it to ask for *anything* in top. Why should it?

>The problem here is that sometimes, the column provider is the first to
>ask for
>\will\svntest\top
>even if your showing only the contents of that folder.

Sorry, which folder is 'that folder'?

>It was. I just didn't take the column provider into the calculation ;)

Well, the comment is wrong then!

>Yes, the shell asks for the status of the parent via the column provider.

Ok, where should I look for this request coming in? It doesn't come into
GetFileStatus (and hence, via a cache miss, into BuildCache) in my scenario.

>definitely not! Try it once - you'll revert your changes after the first
>try ;)

Well, it's been running here all afternoon (probably mainly in 'icon' view
mode) so I'm guessing there must be some other view mode it doesn't work in
- do I need to go into detail mode and turn on some SVN columns?

>I'm currently trying to differ between the column provider calls and the
>icon overlay calls. I think if we can assume that the shell won't call the
>column provider for the parent folder somewhere 'in between' the requests
>for the other items it will work. I'll do some tests and if all goes well
>I'll commit them.

Thanks. There's clearly some subtly I'm missing here. I shall try and
break my version and see what I'm missing.

Cheers,

Will

-- 
Will Dean - Industrial Computing Ltd
will.dean_at_indcomp.co.uk - http://www.indcomp.co.uk/
Elmcroft, Wyke Road, Gillingham, Dorset, SP8 4NG, UK
Tel: +44 1747 831001    Fax: +44 1747 824783
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org