Re: [TSVN] Another go at a patch for SVNFolderStatus

Will Dean wrote:

> Let's not do that then, let's do what it asks for.

That's what I'm trying to do ;)

> There is definitely a bug in there are the moment, which is the following:
>
> The OS asks for
>
> \will\tsvntest\top\sub1
> (which is a folder)
>
> TSVN then mistakes that for a file (by falling out of the if(isFolder)
> clause, chops the end off and
> asks SVN for the status of the folder:
>
> \will\tsvntest\top

And that's usually correct. Imagine the following:
\will\svntest\top\sub1
\will\svntest\top\sub2
\will\svntest\top\file1
\will\svntest\top\file2

now, the shell asks for the status of
\will\svntest\top\sub1

if we then get the status for
\will\svntest\top
we will fetch the status for _all_ the folders and files in that folder,
which includes sub1, sub2, file1 and file2 in one step. That's what this
is about.
The problem here is that sometimes, the column provider is the first to
ask for
\will\svntest\top
even if your showing only the contents of that folder.

> Ignoring anything to do with SVN bugs, surely this wasn't what you
> intended?

It was. I just didn't take the column provider into the calculation ;)

> What I'm seeing is that *nobody* asks for the status of the parent
> folder, but TSVN mistakenly chops down the path and asks SVN for it.

Yes, the shell asks for the status of the parent via the column provider.

> I think if we just looked up the item we were asked for that would be a
> good start!

definitely not! Try it once - you'll revert your changes after the first
try ;)

I'm currently trying to differ between the column provider calls and the
icon overlay calls. I think if we can assume that the shell won't call
the column provider for the parent folder somewhere 'in between' the
requests for the other items it will work. I'll do some tests and if all
goes well I'll commit them.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org