I have made a little patch for the log dialog (which appears on commit).
The patch fixes the annoying behavior, when pressing the button "select
all" (i don't know the exact name, in german it's alle an- / abwählen).
let's explain:
-if i changed several files and commit, the log dialog appears with the
button "select all" checked
-then i uncheck some files
-then i check some unversioned files
result:
the "select all" button is checked anyway, although not all files are
checked
I thought if it's a way to gray out the button if not all items are
checked, on initial open too.
But i could not find a way to gray out the button, because i have not
installed VS .NET 2003.
So please review this little piece of code and correct me. I couldn't
compile it myself.
I think the code for graying a checkbutton is
GetDlgItem(IDC_SELECTALL)->SetCheck(BST_INDETERMINATE);
Martin
--
____________________________________________________________
MicroNova electronic GmbH
Martin Eckardt
Zentrale Entwicklungsdienste
Unterfeldring 17
D-85256 Vierkirchen
Tel.: (08139) 93 00-65
Fax.: (08139) 93 00-80
E-Mail: Martin.Eckardt@micronova.de
WWW: http://www.micronova.de
____________________________________________________________
Index: TortoiseProc/LogPromptDlg.cpp
===================================================================
--- TortoiseProc/LogPromptDlg.cpp (revision 1247)
+++ TortoiseProc/LogPromptDlg.cpp (working copy)
@@ -319,6 +319,11 @@
} // if (data->status == svn_wc_status_deleted)
data->checked = TRUE;
m_nSelected++;
+ // are all items checked
+ if (m_nSelected == m_nTotal)
+ m_bSelectAll = TRUE;
+ else
+ m_bSelectAll = 2; // grayed state???
} // if (m_ListCtrl.GetCheck(pNMLV->iItem))
else
{
@@ -383,6 +388,11 @@
}
data->checked = FALSE;
m_nSelected--;
+ // are all items unchecked
+ if (m_nSelected == 0)
+ m_bSelectAll = 2; // grayed state???
+ else
+ m_bSelectAll = FALSE;
}
m_bBlock = FALSE;
CString sStats;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jun 18 17:09:53 2004