[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-users] Subclipse syncronization view doesn't honor IResource.isHidden()

From: Mike Youngstrom <youngm_at_gmail.com>
Date: Tue, 15 Nov 2011 19:12:24 -0800 (PST)

Hi Stephen thanks for the response.

Based on your comments I've taken a new look at the issue and I think there are 2 separate problems going on:

1. I think there is a bug with hidden resources and syncing incoming changes. If I have a hidden folder with files in version control and those files have incoming changes then if I update those files through the synchronize view then the incoming changes do not disappear from the synchronize view until I do a new Synchronize. I will file an issue for this one.

2. I think my second issue is probably more specific to how the Maven Eclipse plugin is using IResource.isHidden. Consider the following project structure:

-- parentProject
   |-- pom.xml
   |-- childProject
   | |-- pom.xml

If "hide physically nested projects" is enabled Maven Eclipse will create 2 eclipse projects (parentProject and childProject). In the "parentProject" Maven Eclipse will mark the "childProject" folder as hidden since everything in the childProject folder is available in the childProject project.

Assuming all files are in version control, if I synchronize on the parentProject then I will see all incoming and outgoing changes of childProject. I will be able to update and commit these changes. However, if I have a file not yet added to version control in childProject that file will not show up in the synchronize view and may cause me to miss files as I intend to synchronize to my version control.

If instead of synchronizing on parentProject I synchronize on both projects then I will see all outgoing and incoming changes duplicated in both projects and only see my new files in the childProject. This method works but clutters the synchronize view and I don't believe it is obvious to the user why since in their explorer view they aren't seeing the same resources.

I think your default way of managing hidden resources in the synchronize view may be appropriate for most some uses of IResource.isHidden. However, in the Maven use case I think it would be more appropriate to either:
a. Ignore IResource.ishidden all together in Synchronize and commit. Showing all hidden resources.
b. Hide all resources that are hidden even if they are in version control.

Would you consider a feature request to add a preference option that would enable one of the 2 scenarios above? I think I would prefer b. since that would allow synchronize view to better match the Project Explorer and would be more intuitive. Basically allowing resources shown in synchronize view to what is seen in the project explorers.




To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2011-11-16 04:12:27 CET

This is an archived mail posted to the Subclipse Users mailing list.