[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-users] Subclipse syncronization view doesn

From: Stephen Elsemore <selsemore_at_collab.net>
Date: Tue, 15 Nov 2011 09:11:38 -0800 (PST)

Hi Mike,

I don't think that fix is going to change anything in your case because, unlike a filtered resource, a hidden resource still returns true for IResource.exists().

I just spent a few minutes experimenting with hidden resources.

Here are my observations:

The Sync view as well as the non-Sync view commit dialog both already exclude resources that are both unversioned and hidden. IMO, the correct behavior.

The non-Sync view Revert dialog includes resources that are both unversioned and hidden. The Revert dialog from the Sync view does not include these resources. IMO, the Sync view behavior is the correct behavior.

Resources that are hidden, but under version control, do appear in Sync view as well as in all Commit/Revert dialogs. IMO, this is the correct behavior.

Currently, projects/folders are not being decorated as dirty if there are dirty children that are versioned, but hidden. This is because Subclipse drills down into the folders to see if anything is dirty, but in doing this it does not use the INCLUDE_HIDDEN flag when getting a folder's children. I would say this is a bug.

In summary, all that I can see that needs to change is to fix the non-Sync Revert to be consistent with the Sync Revert (exclude unversioned hidden resources), and to fix the decoration of folders with dirty, versioned and hidden children. But maybe I'm missing something in the Maven scenario?

> I saw this issue: http://subclipse.tigris.org/issues/show_bug.cgi?id=1321
>
> It may help with the problem I'm seeing but I don't think it will completely.

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2878310

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2011-11-15 18:11:46 CET

This is an archived mail posted to the Subclipse Users mailing list.