[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Subclipse-users] [PATCH]: "Cannot use javahl nor command line svn client" in vista windows w/ command line interface

From: John E. Leon Guerrero <jguerrero_at_live365.com>
Date: 2007-07-21 02:08:54 CEST

hi folks, i could not find the bug reporting system, but i saw that
these email lists are available for sending patches. please advise if
there is a better way for me to help.

thx,
jlg

===================================
ISSUE:
our windows xp installations are getting this error when we try to use
the command line interface to svn:

"C:\Projects\build\build.xml:112: Cannot use javahl nor command line svn
client"

but the same exact configuration is working just fine under xp.

it turns out that under vista, svn.exe dies if you do not set the
"SystemDrive" environment variable.

org.tigris.subversion.svnclientadapter.commandline.CommandLine.getEnvironmentVariables()
strips out all environment variables from my environment except PATH and
SystemRoot.

===================================
DEMONSTRATION:
here is the test under Windows Vista Ultimate:
C:\Users\jguerrero>set
Path=C:\Tools\svn-win32-1.4.3\bin
SystemDrive=C:
SystemRoot=C:\Windows

C:\Users\jguerrero>svn --version
svn, version 1.4.3 (r23084)
    compiled Jan 18 2007, 07:47:40

Copyright (C) 2000-2006 CollabNet.
Subversion is open source software, see http://subversion.tigris.org/
This product includes software developed by CollabNet
(http://www.Collab.Net/).

The following repository access (RA) modules are available:

* ra_dav : Module for accessing a repository via WebDAV (DeltaV) protocol.
   - handles 'http' scheme
   - handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network protocol.
   - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
   - handles 'file' scheme

C:\Users\jguerrero>set SystemDrive=

C:\Users\jguerrero>svn --version
svn: Can't determine the system config path
===================================

please note: my initial error message is from the 1.0.0 release. i
also tried the 1.1.0-RC2 release which had a different error message.

i downloaded the source as of today (july 20, 2007) and read and patched
this code. unfortunately, i am not skilled enough yet to get the ant
build script to work, so i have not yet tested the patch on my own
system. however, eclipse has checked the code for syntax issues and
there are none. the code modification is straightforward enough.

thanks,
jlg

Index: CommandLine.java
===================================================================
--- CommandLine.java (revision 3209)
+++ CommandLine.java (working copy)
@@ -120,13 +120,16 @@
                 final String path = CmdLineClientAdapter.getEnvironmentVariable("PATH");
                 final String systemRoot = CmdLineClientAdapter.getEnvironmentVariable("SystemRoot");
                 final String aprIconv = CmdLineClientAdapter.getEnvironmentVariable("APR_ICONV_PATH");
- int i = 3;
+ final String systemDrive = CmdLineClientAdapter.getEnvironmentVariable("SystemDrive");
+ int i = 4;
                 if (path != null)
                         i++;
                 if (systemRoot != null)
                         i++;
                 if (aprIconv != null)
                         i++;
+ if (systemDrive != null)
+ i++;
                 String[] lcVars = getLocaleVariables();
                 String[] env = new String[i + lcVars.length];
                 i = 0;
@@ -150,6 +153,10 @@
                         env[i] = "APR_ICONV_PATH=" + aprIconv;
                         i++;
                 }
+ if (systemDrive != null) {
+ env[i] = "SystemDrive=" + systemDrive;
+ i++;
+ }
                 //Add the remaining LC vars
                 for (int j = 0; j < lcVars.length; j++) {
                         env[i] = lcVars[j];

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Sat Jul 21 02:21:59 2007

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.