[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-users] Commit window

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-04-30 17:27:56 CEST

On 4/30/07, MATHUS Baptiste <mathus.b@mipih.fr> wrote:
>
> > On 4/30/07, MATHUS Baptiste <mathus.b@mipih.fr> wrote:
> > > Hey,
> > >
> > > When I commit, I often write a lot :-). The thing is I
> > don't like to press enter when it's not semantically correct
> > :). So I end up having very long lines and a big horizontal
> > scrolling... It's not very readable.
> > >
> > > So, my question is: has it already been discussed that some
> > automatic return to the line could be added? Obviously, I
> > don't mean subclipse should add \n when reaching the max
> > width, but put the suite of the sentence on the next line
> > (quite classical behaviour).
> > >
> > > I seem to remember that for instance TortoiseSvn does this
> > and shows a small "circular" arrow at the end on the "cut"
> > line. I'm not sure the arrow is compulsory, but at least I
> > think subclipse should offer this behaviour as an option.
> > >
> > > What do you think?
> >
> > I think you should press enter and enter line breaks. Don't
> > you have any processes that use svn:log? If you do not add
> > hard returns on your messages you are forcing every piece of
> > software you use to have logic to reformat the log messages.
>
> Well. I prefer staying semantic in my logs. Then I'm able to wrap at 80, 100 or whatever character count. I only make newlines when I'm beginning a new paragraph.
>
> I guess I will be able to write some (perl|python|ruby|groovy|whatever) one-line that'll handle a newline every n characters in less than 2 hours, even if I'm no expert in those languages :-).
>
> >
> > I use TortoiseSVN as well and I do not recall it having a
> > feature like the one you describe. I think you might be
> > thinking of the viewing of log messages and we have the same feature.
>
> Well, I disagree. See screenshot.
>
> "Example of a line without any newline done by an enter key press... You see that it's a lot more readable. And so no, TortoiseSvn is not behaving the same since it lets you write how you want. The "circular" arrow at the end of the precedent lines are in fact present. Everything I just wrote is visible. I agree I could add newlines where adviced, but I'm not forced to, though I can see everything I wrote."
>
> >
> > We do not do anything in the commit dialog to wrap your lines
> > because it interferes with creating a properly formatted log
> > message which is important to a lot of users. That is also
> > why us and TortoiseSVN have a setting to add a hint line to
>
> Argh. This hint is exactly what I'm talking about. Though I can't find it in subclipse?! Could you help me find it, stupid me?

The hint I am talking about is different than this. You can see it in
this post:

http://markphip.blogspot.com/2007/01/features-of-subclipse-commit-dialog.html

I just tried TortoiseSVN again and I see what they are doing. They
are using the hint I reference as an indicator to them as to how the
dialog should behave. In other words, if the line width hint is
supposed to show, then the dialog should not auto-wrap text.
Basically it should work like our dialog works now. But if that hint
is not present than it should just auto-wrap the text. I always have
that hint setup on my projects so I do not see the auto-wrap feature
generally in TortoiseSVN.

That seems like a reasonable way to handle this to me. Please file an
issue in our issue tracker. Note that we will most likely not be able
to show the soft-wrap characters that they are showing in their
dialog. It will just be up to what the SWT control supports.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Mon Apr 30 17:28:07 2007

This is an archived mail posted to the Subclipse Users mailing list.