[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature request: Allow right click to set svn:ignore in commit dialog

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-25 14:38:10 CET

Marc Sherman <msherman@projectile.ca> wrote on 11/25/2005 08:21:15 AM:

> Mark Phippard wrote:
> >
> > If you can make it work without a ridculous amount of new code, then I
> > would certainly review it.
> Ok. You didn't address the technical question, though -- why do you
> think I'd still need to do the rescan? Was I missing something in the
> logic that led me to believe that I wouldn't?

svn:ignore supports patterns, so you would have to add pattern matching
code. Also, you would not be able to use the existing UI for adding to
the svn:ignore property because if you do, you have no way of knowing from
the commit dialog what the property looks like. You would also have to be
sure that the folder where the property is set gets added to the dialog as
a commit of the property change.

> > I do think that Eugene brought up some UI
> > points that are valid. I think the only option I would consider from
a UI
> > point of view is a right-click menu.
> Um, now I'm confused. :) Eugene said that Eclipse UI standards forbid a

> right-click menu in a dialog. Are you saying I should break the
> standards, or I should _re-consider_ the right-click menu?

I am not aware of any documentation of Eclipse UI standards and if it
truly is forbidden then I am sure that there isn't any API to add the menu
in the first place. My point was that of the UI choices, that is the best


Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
Received on Sat Nov 26 00:38:10 2005

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.