Re: JhlClientAdapter's output to console if library is missing

Mark Phippard schrieb am 10.09.2005 20:05:

>I have a few comments.
>
>1) As of 0.9.33, when we include JavaSVN, I really do not see how it
>would be possible for it not to load. We include everything it needs, so
>why would it fail?
>
>

It's not the problem that JavaSVN is not loadable. JavaSVN's
JavaSvnClientAdapter class calls JhlClientAdapterFactory.setup(), thus
JhlClientAdapterFactory's error messages are printed to the console:

I call
SVNClientAdapterFactory.createSVNClient(JavaSvnClientAdapterFactory.JAVASVN_CLIENT)

The JavaSvnClientAdapterFactory creates a new JavaSvnClientAdapter.

The constructor of JavaSvnClientAdapter calls
JavaSvnClientAdapter.getSvnAdmin().

JavaSvnClientAdapter.getSvnAdmin() calls JhlClientAdapterFactory.setup().

JhlClientAdapterFactory.setup() calls JhlClientAdapter.isAvailable().

Because javahl is not available (therefore I use JavaSVN), the messages
are printed to the console.

Here's the stack:

Thread [main] (Suspended (breakpoint at line 48 in JhlClientAdapterFactory))
    JhlClientAdapterFactory.setup() line: 48
    JavaSvnClientAdapter.getSvnAdmin() line: 58
    JavaSvnClientAdapter.<init>() line: 43
    JavaSvnClientAdapterFactory.createSVNClientImpl() line: 33
    SVNClientAdapterFactory.createSVNClient(String) line: 60
    SubversionToolClientadapterJavaSvnTest.createISubversionTool() line: 46
    SubversionToolClientadapterJavaSvnTest(ISubversionToolTest).setUp()
line: 143
    SubversionToolClientadapterJavaSvnTest(TestCase).runBare() line: 125
    TestResult$1.protect() line: 106
    TestResult.runProtected(Test, Protectable) line: 124
    TestResult.run(TestCase) line: 109
    SubversionToolClientadapterJavaSvnTest(TestCase).run(TestResult)
line: 118
    RemoteTestRunner.runTests(String[], String) line: 478
    RemoteTestRunner.run() line: 344
    RemoteTestRunner.main(String[]) line: 196

>2) In svnClientAdapter, we do not currently output any errors for
>JavaSVN, it might output its own.
>
>

The output comes from JhlClientAdapter.isAvailable().

>3) For JavaHL, we only output to the system console, which you normally
>would not be able to see when running Eclipse. However, we also capture
>the errors in Subclipse and show them to you in preferences under
>Team->SVN when you try to select JavaHL.
>
>

I'm using svnClientAdapter in my own application, and there is that
confusing output on the console. I'm not talking about the Eclipse
Plugin, I mean the svnClientAdapter library. Sorry about the inexactness
in my first mail that started this thread.

Regards,
    Martin