Re: [Subclipse-dev] [PATCH]: "Cannot use javahl nor command line svn client" in vista windows w/ command line interface

Hi guys,

The same problem happened to me with svnClientAdapter.jar:
Specification-Version: 0.9.100
Implementation-Title: org.tigris.subversion.svnclientadapter
Implementation-Version: r2401 (June 19 2006)

I've got latest sources from trunk (r3373), patched it and confirmed the
fix.
Patch details are below. That would be very nice to have it applied to
trunk.

Index: CommandLine.java
===================================================================
--- CommandLine.java (revision 3373)
+++ CommandLine.java (working copy)
@@ -114,17 +114,21 @@
      * Without this variable present, the windows' DNS resolver does not
work.
      * <code>APR_ICONV_PATH</code> is required on windows platform for
UTF-8 translation.
      * The <code>PATH</code> is there, well, just to be sure ;-)
+ *<code>SystemDrive</code> - is required on Windows Vista platform.
SVN.exe (most recent version available today - 1.4.5) cannot start without
it (Error message: svn: Can't determine the system config path).
      */
         protected String[] getEnvironmentVariables()
         {
                 final String path = CmdLineClientAdapter.getEnvironmentVariable("PATH");
                 final String systemRoot =
CmdLineClientAdapter.getEnvironmentVariable("SystemRoot");
+ final String systemDrive =
CmdLineClientAdapter.getEnvironmentVariable("SystemDrive");
                 final String aprIconv =
CmdLineClientAdapter.getEnvironmentVariable("APR_ICONV_PATH");
                 int i = 3;
                 if (path != null)
                         i++;
                 if (systemRoot != null)
                         i++;
+ if (systemDrive != null)
+ i++;
                 if (aprIconv != null)
                         i++;
                 String[] lcVars = getLocaleVariables();
@@ -146,6 +150,10 @@
                         env[i] = "SystemRoot=" + systemRoot;
                         i++;
                 }
+ if (systemDrive != null) {
+ env[i] = "SystemDrive=" + systemDrive;
+ i++;
+ }
                 if (aprIconv != null) {
                         env[i] = "APR_ICONV_PATH=" + aprIconv;
                         i++;

Thanks,
Olexiy.

-- 
View this message in context: http://www.nabble.com/-PATCH-%3A--%22Cannot-use-javahl-nor-command-line-svn-client%22-in-vista-windows-w--command-line-interface-tf4120278.html#a12912165
Sent from the subclipse - dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org