[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Bug introduced with 1.1.9 - LockDialog

From: Mark Phippard <markphip_at_gmail.com>
Date: 2006-12-08 22:35:41 CET

On 12/8/06, Thomas M. Hofmann <email@thomashofmann.com> wrote:
>
> I installed 1.1.9 today and immediately had problems with file locking.
>
> I then debugged the code and found the code changes for the "Improve
> handling of read-only files that are not managed by Subclipse" to be the
> problem. The new code prompts for all files managed by subclipse and shows
> the LockDialog. It should only prompt for files that have the svn:needs lock
> property set.
>
> Now, when I modify a file in the workspace that is under version control I
> get the LockDialog two times. I believe there are two modifications and
> because pressing OK in the first one does not do anything (no read only flag
> is removed because there is non to remove).
>
> Anyway there should not be any LockDialog at all. It all works with 1.1.8.
>
> The problematic code is in SVNFileModificationValidator in the method public
> IStatus validateEdit(IFile[] files, Object context).
> There, all managed files are determined and then the LockDialog is invoked
> like this: if
> (!svnFileModificationValidatorPrompt.prompt(managedFiles,
> context))

The list of files should just be the ones that are read only though.
We do not actually check for the property, we base this on the read
only attribute. When I test this, I do not see a problem and
fundamentally the code did not really change it was just restructured
so that it could also handle unmanaged files that were read only.

I am not saying a bug was not introduced either. Clearly one was
introduced, I'll probably need some additional info to figure it out.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Fri Dec 8 22:35:45 2006

This is an archived mail posted to the Subclipse Dev mailing list.