[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Subclipse-dev] Bug introduced with 1.1.9 - LockDialog

From: Thomas M. Hofmann <email_at_thomashofmann.com>
Date: 2006-12-08 22:17:45 CET

Hi,
 
I installed 1.1.9 today and immediately had problems with file locking.
 
I then debugged the code and found the code changes for the "Improve
handling of read-only files that are not managed by Subclipse" to be the
problem. The new code prompts for all files managed by subclipse and
shows the LockDialog. It should only prompt for files that have the
svn:needs lock property set.
 
Now, when I modify a file in the workspace that is under version control
I get the LockDialog two times. I believe there are two modifications
and because pressing OK in the first one does not do anything (no read
only flag is removed because there is non to remove).
 
Anyway there should not be any LockDialog at all. It all works with
1.1.8.
 
The problematic code is in SVNFileModificationValidator in the method
public IStatus validateEdit(IFile[] files, Object context).
There, all managed files are determined and then the LockDialog is
invoked like this: if
(!svnFileModificationValidatorPrompt.prompt(managedFiles, context))
 
Regards,
 
Thomas
 
 
 
 
 
Received on Fri Dec 8 22:27:32 2006

This is an archived mail posted to the Subclipse Dev mailing list.