[snip]
> > But as I see a simple replacement of CmdLineClientAdapter line 878 to
> > _cmd.copy(String, String) will not fully work because then the revision
> will
> > be ignored. Looks like there is more work to do.
> > There are just two cases: *->WC without message and *->URL with message
> and
> > the SvnCommandLine class handles this in two copy functions but the
> > copy(String, String) function is missing the revision when the source is
> an
> > URL.
> > change copy(String, String) (line 249ff) to copy(String, String, String)
> > where the third string is the revision which can be handled like in
> > copy(String, String, String, String) above:
> > if (revision != null) {
> > args.add("-r");
> > args.add(validRev(revision));
> > }
>
> I do not think that is the right approach. The WC to WC copy method
> should not take a revision argument as it is supposed to copy the contents
> on one WC to another. Now that I know what you wanted to do, I think I
> have committed the correct fix.
No, I was talking about URL->WC which does need a revision for the source,
whereas WC->WC does not need one.
But both cases result in a call to copy(String, String) right now without a
revision.
Therefore I would like to extend the function with a revision which would be
null for a WC->WC copy.
> Are you able to test the same scenario with the other adapters?
Umm, not really. I deperately need a time donation for that ;-)
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Tue Oct 17 21:31:51 2006