[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] unavailable JavaSVN causes NoClassDefFoundError

From: Oliver Niekrenz <oliver_at_niekrenz.de>
Date: 2006-10-17 21:02:34 CEST

> I did not make any change to this:
>
> 2) using the commandline client a WC->WC copy failed
>
> I think this is an svnAnt problem. The client adapter has a method for a
> WC->WC copy:

Ah, sorry, I used URL->WC copy

svnant Copy calls (line93):
  svnClient.copy(SVNUrl, File, SVNRevision)

CmdLineClientAdapter copy(SVNUrl, File, SVNRevision) (line 875ff) calls:
 _cmd.copy(String, String, null, String) <--- !!!!!

SvnCommandLine copy(String, String, String, String) (line 225ff) does this:
  args.addLogMessage(message);

svnant works rights for all WC/URL permutations but the command line adapter
does not.

But as I see a simple replacement of CmdLineClientAdapter line 878 to
_cmd.copy(String, String) will not fully work because then the revision will
be ignored. Looks like there is more work to do.
There are just two cases: *->WC without message and *->URL with message and
the SvnCommandLine class handles this in two copy functions but the
copy(String, String) function is missing the revision when the source is an
URL.
change copy(String, String) (line 249ff) to copy(String, String, String)
where the third string is the revision which can be handled like in
copy(String, String, String, String) above:
if (revision != null) {
  args.add("-r");
  args.add(validRev(revision));
}

And change CmdLineAdapter:
line 878: _cmd.copy(toString(srcUrl, toString(destPath),
toString(revision));
line 410: _cmd.copy(toString(srcPath), toString(destPath), null);

I think this will do the trick
Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Tue Oct 17 21:02:45 2006

This is an archived mail posted to the Subclipse Dev mailing list.