On 2/2/06, Mark Phippard <markp@softlanding.com> wrote:
> A few quick comments.
>
> 1) I think some new classes are missing from the patch. You have to do
> Team -> Add on the classes so that they are included.
>
Ok, I'm going to move from the 1.0 branch to trunk and redo the patch.
> 2) In plugin.properties, you seemed to add the same literal twice.
>
I wasn't sure what the convention was if you're using the same text in
two different places in the UI. I guess if some time later we want
different text in those places, we can add another literal, so I'll
take that one out.
> 3) The Non-SVN Conflicts filter is on by default. It doesn't seem like
> it should be.
Ok, I'll look at that. Not sure where that gets set.
>
> 4) I am mildly concerned that people will not understand what Delete
> unmanaged resources means. Technically the item is Added, and will become
> unmanaged as part of the revert. Also, other items that are unmanaged
> will not be deleted because they would not have shown in the revert
> dialog. I do not have any great ideas here on how to improve it.
>
I was thinking about what files show up in the revert dialog, and
wondering if we could have unmanaged resources show up there, so that
they would be deleted if the delete unmanaged resources option were
set. Is this something you would consider? Or maybe it's different
enough that it should be it's own operation? It's still an operation
which does something related to the repository state.
> 5) Right now, it is just the Revert option where this is implemented,
> correct? What other places are you planning on using it?
Where else would be appropriate? Does a Switch normally leave
unversioned files around? If so, that would be another place to
consider it.
I'll try and resend the patches, resynced to trunk and with the
missing files tonight. But if not then, this weekend sometime.
Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Fri Feb 3 15:13:08 2006