[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] [PATCH] delete unmanaged/filter conflics patch - Take II

From: Mark Phippard <markp_at_softlanding.com>
Date: 2006-02-02 15:50:50 CET

A few quick comments.

1) I think some new classes are missing from the patch. You have to do
Team -> Add on the classes so that they are included.

2) In plugin.properties, you seemed to add the same literal twice.

3) The Non-SVN Conflicts filter is on by default. It doesn't seem like
it should be.

4) I am mildly concerned that people will not understand what Delete
unmanaged resources means. Technically the item is Added, and will become
unmanaged as part of the revert. Also, other items that are unmanaged
will not be deleted because they would not have shown in the revert
dialog. I do not have any great ideas here on how to improve it.

5) Right now, it is just the Revert option where this is implemented,
correct? What other places are you planning on using it?


Paul Lorenz <plorenz@gmail.com> wrote on 02/02/2006 12:51:49 AM:

> I've updated the delete unmanaged resources on revert patch to have a
> checkbox on the dialog itself. The checkbox defaults to whatever is
> specified in the Team/SVN preferences.
> I also updated the conflicts filter, there was a small bug where it
> wasn't checking that resources were available before looking for the
> warning marker. I also made the JDT dependencies optional.
> I think the reason that isTextConflicted wasn't working is because I
> cancelled a merge part way through. The warning marker was created,
> but the status apparently wasn't updated, which seems indicative of a
> bug somewhere.
> Anyway, let me know how the patches look and if/how they could be
> Also, should I be working off of trunk or the 1.0 branch?

Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.

To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Thu Feb 2 15:52:07 2006

This is an archived mail posted to the Subclipse Dev mailing list.