[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-dev] JavaHL API Wishlist

From: Mark Phippard <markp_at_softlanding.com>
Date: 2005-11-16 20:58:29 CET

"Alexander Kitaev" <alex@tmate.org> wrote on 11/16/2005 02:46:52 PM:

> >Peg revisions in svn log
> This is already supported in JavaSVN internal API, so I could provide
log
> method with additional parameter in SVNClientImpl.

We could use a version that just adds peg revision to the existing
signature that includes limit. Something like:

    /**
     * Retrieve the log messages for an item
     * @param path path or url to get the log message for.
     * @param pegRevision peg revision if url is specified
     * @param revisionStart first revision to show
     * @param revisionEnd last revision to show
     * @param stopOnCopy do not continue on copy operations
     * @param discoverPath returns the paths of the changed items in the
     * returned objects
     * @param limit limit the number of log messages (if 0 or less
no
     * limit)
     * @return array of LogMessages
     * @since 1.2
     */
    LogMessage[] logMessages(String path, Revision pegRevision, Revision
revisionStart,
                             Revision revisionEnd, boolean stopOnCopy,
                             boolean discoverPath, long limit)
            throws ClientException;

Since the way you are using the API I would always want peg revision to be
HEAD, I could just add this in the JavaSVNClientAdapter without changing
our interface. So that would be good.

> >Network statistics
> Currently JavaSVN could report amount of bytes sent over network (but it
> doesn't take in account data compression or crypto overhead). There is
no
> way to get "total" amount for the whole operation so far, but it works
for
> any of supported protocol, not only for http. Current implementation
could
> report amount of bytes sent or received for each 1024 bytes of the data
> processed.
>
> If you'd like I could add "extended" API methods to JavaSVN's version of
> SVNClient next week. Please let me know what is your idea of progress
API? I
> think there could be additional interface that extends Notify2 with the
> "progress" method:
>
> public void progress(long bytesSent, long totalBytesToSend, long
> bytesReceived, long totalBytesToReceive);
>
> "total" values will be always set to -1 for now, and sent/received
counters
> could be zeroed at the beginning of each SVNClient operation.

I would suggest holding off on this for now. I am not really ready to do
anything on these yet and I would have to think about how these sorts of
changes (especially the progress change) could be conditionally worked in.
 If you want to do it, then yes I was thinking implementation would be the
same as what you proposed.

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________
Received on Thu Nov 17 06:58:29 2005

This is an archived mail posted to the Subclipse Dev mailing list.